Skip to content

Add Media Unit tests - Part 2#114

Merged
yangyansong-adbe merged 17 commits intoadobe:mediafrom
addb:mediaUnitTest2
Nov 16, 2023
Merged

Add Media Unit tests - Part 2#114
yangyansong-adbe merged 17 commits intoadobe:mediafrom
addb:mediaUnitTest2

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Nov 14, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

''' set the session inactive and idle
m._isIdle = true
''' set the session inactive
m.close(true)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return statement

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the return type to void

@yangyansong-adbe yangyansong-adbe merged commit a820ab5 into adobe:media Nov 16, 2023
@addb addb deleted the mediaUnitTest2 branch November 22, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants