Implement session Manager - Initial Structure, Setup and Usage#106
Merged
addb merged 8 commits intoadobe:mediafrom Nov 10, 2023
Merged
Implement session Manager - Initial Structure, Setup and Usage#106addb merged 8 commits intoadobe:mediafrom
addb merged 8 commits intoadobe:mediafrom
Conversation
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
yangyansong-adbe
approved these changes
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
| @@ -0,0 +1,266 @@ | |||
| ' ********************** Copyright 2023 Adobe. All rights reserved. ********************** | |||
There was a problem hiding this comment.
MediaSession -> mediaSession for consistency.
Contributor
Author
There was a problem hiding this comment.
I will do this change at the end.
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
praveek
reviewed
Nov 9, 2023
…sions. Added todos in MediaSession.
… level. Added code to handle sessionstart failure.
praveek
reviewed
Nov 10, 2023
code/main/media/MediaSession.brs
Outdated
| if isAd then | ||
| return m._sessionConfig["adpinginterval"] | ||
| interval = m._sessionConfig[m._PUBLIC_CONSTANTS.MEDIA_SESSION_CONFIGURATION.AD_PING_INTERVAL] | ||
| if interval >= m._MIN_AD_PING_INTERVAL_SEC and interval <= _MAX_AD_PING_INTERVAL_SEC then |
praveek
approved these changes
Nov 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MediaSessionManager.brs:
MediaSession.brs:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: