Cleanup for the media tracking PR#105
Merged
yangyansong-adbe merged 5 commits intoadobe:mediafrom Nov 8, 2023
Merged
Conversation
addb
reviewed
Nov 7, 2023
| end if | ||
|
|
||
| sessionId = m._private.mediaSession.startNewSession() | ||
| playhead = 0 |
Contributor
There was a problem hiding this comment.
There is a position variable on L285, can we check if the playhead is valid there and combine this logic.
Contributor
Author
There was a problem hiding this comment.
The L285 code is used to handle the position/playhead of the previous session. It might be confusing to mix them together.
Contributor
There was a problem hiding this comment.
We will get getting Playhead from customer right? So ideally we dont need any playhead logic. This is for fallback? What about sessionEnd?
Contributor
Author
There was a problem hiding this comment.
Discussed offline and decided to move this logic from the API layer to the SDK (task node) layer in another PR.
addb
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.