MOB-22621 | Fetching timeout value from configuration#128
Merged
ishwetansh merged 40 commits intoadobe:dev-v5.3.0from Feb 19, 2025
Merged
MOB-22621 | Fetching timeout value from configuration#128ishwetansh merged 40 commits intoadobe:dev-v5.3.0from
ishwetansh merged 40 commits intoadobe:dev-v5.3.0from
Conversation
sbenedicadb
reviewed
Feb 5, 2025
Apologies for the delay. I missed the GH notification. Another way to simplify the logic is to avoid using MobileCore.dispatchWithResponseCallback in the public API layer. Since Core handles the timeout, Optimize should be aware of the timeout when making the API call. Instead
|
praveek
reviewed
Feb 12, 2025
praveek
reviewed
Feb 12, 2025
praveek
reviewed
Feb 14, 2025
praveek
reviewed
Feb 14, 2025
praveek
reviewed
Feb 14, 2025
praveek
reviewed
Feb 18, 2025
praveek
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fetching timeout value from configuration and using it when there is no timeout passed.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: