[MOB-22477] - Added support for debug events and separate cache for Preview Propositions#120
Merged
akhiljain1907 merged 5 commits intoadobe:dev-v5.2.0from Nov 28, 2024
Merged
Conversation
…on to provide requested data from preview cache if present.
| XCTAssertEqual("com.adobe.eventSource.notification", dispatchedEvent?.source) | ||
|
|
||
| XCTAssertEqual(1, optimize.previewCachedPropositions.count) | ||
| XCTAssertTrue(optimize.cachedPropositions.isEmpty) |
Contributor
There was a problem hiding this comment.
Can we check the previewed response is returned here when both Optimize.getPropositions and Optimize.onPropositionsUpdate are called?
Contributor
There was a problem hiding this comment.
Can we also add a test case for
- Debug Event received for decisionScopeA -> Optimize.getPropositions(decisionScopeA, decisionScopeB) and check the response we receive for both scopes
- Debug event received for decisionScopeA -> Optimize.updatePropositions(decisionScopeA, decisionScopeB) -> Optimize.getPropositions(decisionScopeA, decisionScopeB) and check the response we receive for both scopes
Contributor
Author
There was a problem hiding this comment.
Done. i have added test cases where we receive debug events for a scope and check for get calls for multiple scope and also update and get for multiple scopes.
… get and update calls
spoorthipujariadobe
previously approved these changes
Nov 26, 2024
spoorthipujariadobe
previously approved these changes
Nov 26, 2024
Contributor
spoorthipujariadobe
left a comment
There was a problem hiding this comment.
nit: Can we check previewCachedPropositions is empty in testClearCachedPropositions
spoorthipujariadobe
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we've added a separate preview cache and modified handling of get proposition to provide requested data from preview cache if present.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: