[MOB-22281] - Public API Changes with Configurable timeout value for Update/ Get proposition#119
Merged
ishwetansh merged 10 commits intoadobe:dev-v5.2.0from Nov 21, 2024
Merged
Conversation
Dev v5.1.0 -> Staging
Staging to Main Optimize 5.1.0
sbenedicadb
approved these changes
Nov 14, 2024
Member
sbenedicadb
left a comment
There was a problem hiding this comment.
code looks fine - would like to see some tests where we force a timeout and ensure the error is returned as expected.
spoorthipujariadobe
approved these changes
Nov 15, 2024
Contributor
spoorthipujariadobe
left a comment
There was a problem hiding this comment.
Please make sure to document the new API on github and public docs
sbenedicadb
reviewed
Nov 20, 2024
Member
sbenedicadb
left a comment
There was a problem hiding this comment.
tests looking better, just a few small updates requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Added customizable timeout to getPropositions and updatePropositions functions, allowing users to define how long to wait for responses before triggering a timeout error.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: