Skip to content

[PLATIR-43864] Changed Offer Score value from Int to Double#113

Merged
ishwetansh merged 3 commits intoadobe:dev-v5.0.2from
ishwetansh:fix/offers
Sep 27, 2024
Merged

[PLATIR-43864] Changed Offer Score value from Int to Double#113
ishwetansh merged 3 commits intoadobe:dev-v5.0.2from
ishwetansh:fix/offers

Conversation

@ishwetansh
Copy link
Copy Markdown
Contributor

Description

Changing the data type of Score property from the offer entity to double.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ishwetansh ishwetansh added the bug Something isn't working label Sep 26, 2024
@akhiljain1907 akhiljain1907 self-requested a review September 26, 2024 16:42
Copy link
Copy Markdown
Contributor

@spoorthipujariadobe spoorthipujariadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please add a test in OfferTests where score is a double value and assert that the offer is created properly?

@ishwetansh ishwetansh merged commit 3c881cd into adobe:dev-v5.0.2 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants