Mob 20807 - Providing error details received by Edge in updateProposition api callback#111
Merged
akhiljain1907 merged 8 commits intoadobe:dev-v5.0.2from Sep 26, 2024
Merged
Conversation
…roposition api callback.
…ios into MOB-20807 # Conflicts: # Sources/AEPOptimize/OptimizeConstants.swift
…rom different request -added alert UI for error handling in update proposition for test app
…ional information received from Edge error response
Sources/AEPOptimize/Optimize.swift
Outdated
|
|
||
| /// a dictionary containing the update event IDs and corresponding errors as received from Edge SDK | ||
| private var _errorUpdateRequestEventIds: [String: AEPOptimizeError] = [:] | ||
| private var errorUpdateRequestEventIds: [String: AEPOptimizeError] { |
Contributor
There was a problem hiding this comment.
nit: is it ok if we call this _updateRequestEventIdsError instead to be symmetrical with _updateRequestEventIdsInProgress?
Contributor
spoorthipujariadobe
left a comment
There was a problem hiding this comment.
Changes look good, please add tests
…AEPOptimizeError received in update proposition callback fixed build errors for AEPOptimize objective-C test app
…dge response instead of modifying existing test
Contributor
Author
|
Hi @spoorthipujariadobe, i have added an integration test for updateProposition_invalidEdgeResponse. Please check and review once more. |
spoorthipujariadobe
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR supports handling of error response received (if any) from Experience Edge and sending them back to update Proposition api's completion handler. Currently we are suppressing recoverable errors at our end as those are already being retried on Edge SDK.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: