MOB-19932 - Get proposition request event handling #109
Merged
navratan-soni merged 4 commits intoadobe:dev-v5.0.2from Aug 28, 2024
Merged
MOB-19932 - Get proposition request event handling #109navratan-soni merged 4 commits intoadobe:dev-v5.0.2from
navratan-soni merged 4 commits intoadobe:dev-v5.0.2from
Conversation
sbenedicadb
requested changes
Aug 22, 2024
Member
|
code looks good - a couple small changes that need to be made |
Contributor
Author
|
@sbenedicadb, I have updated the code as per your suggestions. Thanks :) |
Contributor
Author
|
@spoorthipujariadobe , I have update the code as per your suggestions & also added a test case. |
sbenedicadb
approved these changes
Aug 27, 2024
spoorthipujariadobe
approved these changes
Aug 27, 2024
spoorthipujariadobe
approved these changes
Aug 27, 2024
Contributor
spoorthipujariadobe
left a comment
There was a problem hiding this comment.
Great job on your first PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Case 1: If getPropositions() is called for a decision scope (e.g., scope1) and there's an updatePropositions() in progress for a different scope (e.g., scope2, scope3), return the value for scope1 immediately without waiting.
Use Case 2: If getPropositions() is called for a decision scope that is currently being updated (e.g., scope1), wait for the updatePropositions() to complete before returning the response.
Related Issue
Motivation and Context
How Has This Been Tested?
Through Unit testing and manual scenario based testing.
Screenshots (if appropriate):
Types of changes
Checklist: