Conversation
kevinlind
approved these changes
Oct 16, 2020
Contributor
|
I think we'll also need to update the version on the build target. Not sure it makes much of a difference though. |
Contributor
Author
|
@nporter-adbe are we doing this for core extensions already? I will look into this |
Contributor
|
We're not currently doing this, but we're not really versioning the beta as is being done here. Rather just have customers point to the main branch of the repo to get the latest beta build. |
Codecov Report
@@ Coverage Diff @@
## dev #79 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 16 16
Lines 573 573
=======================================
Hits 513 513
Misses 60 60 |
Contributor
Author
|
@nporter-adbe updated the framework version to 1.0.0-beta-1 as well |
nporter-adbe
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: