Skip to content

Cleanup & demo app setup #72

Merged
imiron-git merged 2 commits intoadobe:devfrom
emdobrin:review-app
Sep 29, 2020
Merged

Cleanup & demo app setup #72
imiron-git merged 2 commits intoadobe:devfrom
emdobrin:review-app

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

  • Clean up test data
  • Add steps to configure the demo app

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested a review from kevinlind September 29, 2020 18:57
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2020

Codecov Report

Merging #72 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #72   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          16       16           
  Lines         497      497           
=======================================
  Hits          445      445           
  Misses         52       52           

Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will need to update the sdkdocs with the updated steps to add the config ID.

make open-app
~~~

Configure the Launch Mobile Property and set up the Environment File ID in the app. Follow these steps to [Configure the demo app](https://aep-sdks.gitbook.io/docs/beta/experience-platform-extension/commerce-demo-app-setup#configure-the-demo-app).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this gitbook document with the updated steps to add the config ID.

@imiron-git imiron-git merged commit ccf411d into adobe:dev Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants