Skip to content

[AMSDK-10030] Cleanup documentation, formatting#65

Merged
emdobrin merged 5 commits intoadobe:devfrom
emdobrin:review
Sep 26, 2020
Merged

[AMSDK-10030] Cleanup documentation, formatting#65
emdobrin merged 5 commits intoadobe:devfrom
emdobrin:review

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

Few more changes to come in the next PR, containing Constants changes, more doc updates and swift lint warning fixes

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested a review from kevinlind September 26, 2020 00:32
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor comment.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2020

Codecov Report

Merging #65 into dev will decrease coverage by 0.14%.
The diff coverage is 66.67%.

@@            Coverage Diff             @@
##              dev      #65      +/-   ##
==========================================
- Coverage   88.25%   88.11%   -0.14%     
==========================================
  Files          17       17              
  Lines         570      555      -15     
==========================================
- Hits          503      489      -14     
+ Misses         67       66       -1     

@emdobrin emdobrin merged commit 9c0bc5e into adobe:dev Sep 26, 2020
@emdobrin emdobrin changed the title Cleanup documentation, formatting [AMSDK-10030] Cleanup documentation, formatting Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants