Use ObjC friendly name that won't conflict with module name#58
Merged
nporter-adbe merged 1 commit intodevfrom Sep 1, 2020
Merged
Use ObjC friendly name that won't conflict with module name#58nporter-adbe merged 1 commit intodevfrom
nporter-adbe merged 1 commit intodevfrom
Conversation
kevinlind
approved these changes
Sep 1, 2020
Contributor
|
Should we rather change the module name (which is less used) than the class name? Did we decide that this will be the go to public approach for core as well? |
Contributor
Author
|
@emdobrin Yes, this naming convention was decided to be used for core. Mainly since we aren't interested in renaming the Xcode project, cocoapod, and quite a few other resources such as makefile. |
Contributor
|
Got it, thanks @nporter-adbe. My only concern was that the obj-c name became pretty long and wanted to see if there is any way we can avoid that since it will be used frequently in customer's implementation, but we will need to first decide the final name to determine that is an issue. |
emdobrin
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found an issue that would only manifest in core where if you include the XCFramework into a swift app that it would have trouble distinguishing AEPCore (module) and AEPCore (objc class). We thought that this issue would not manifest since the prefixed class name is only being exported to objc. However, it turns out this is not the case and it still conflicts.
To solve this we simply adding the AEPMobile prefix to our classes for now.