Integrate with Core SPM#57
Merged
emdobrin merged 19 commits intoadobe:core-spmfrom Aug 28, 2020
sbenedicadb:spm-support
Merged
Conversation
git-subtree-dir: aepsdk-core-ios git-subtree-split: f525ffd130f0063071f60784b34fbb535052ae01
emdobrin
reviewed
Aug 26, 2020
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
@sbenedicadb thanks for pushing these changes. I added couple comments and a few todos where we need to revisit things.
| try? api.clearSharedEventStates() | ||
| if event.source == FakeIdentityExtension.eventClearState { | ||
| // TODO: not supported anymore | ||
| // try? api.clearSharedEventStates() |
Contributor
There was a problem hiding this comment.
@sbenedicadb any plan in implementing this and unregisterExtension or did we drop the support for it?
| import AEPCore | ||
| import AEPExperiencePlatform | ||
| import AEPIdentity | ||
| //import AEPLifecycle |
Contributor
There was a problem hiding this comment.
@sbenedicadb not sure why this module is not found, it's imported as AEPIdentity.
Member
Author
|
@emdobrin i wasn't planning to work on this any more at this point. are you ok to take it from here? |
emdobrin
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Libraries for Distributionin build settings