Conversation
Contributor
Author
|
@emdobrin @kevinlind any feedback? |
kevinlind
approved these changes
Aug 20, 2020
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
This looks good, though the PR description doesn't appear to match what was done. Is there a task to evaluate and make the changes to the project to change from a static lib to dynamic framework?
Contributor
Author
|
@kevinlind Sorry, the description was unclear, I've updated it. I have also created a task to get the static library switched to a dynamic library AMSDK-10474. |
emdobrin
approved these changes
Aug 21, 2020
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Looks good @nporter-adbe. Steve was looking into converting to dynamic libs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes classes and APIs to Obj-C, however, we currently cannot import the ExEdge extension into a sample objc app without a fair amount of work. This is caused by it being a static lib. We should update the project to produce a framework rather than a static lib so it is consistent with the rest of the swift extensions and is easier to use in objc.