Skip to content

[AMSDK-10259] Change Float to Double in Commerce app#51

Merged
kevinlind merged 4 commits intoadobe:devfrom
emdobrin:AMSDK-10259
Jul 20, 2020
Merged

[AMSDK-10259] Change Float to Double in Commerce app#51
kevinlind merged 4 commits intoadobe:devfrom
emdobrin:AMSDK-10259

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Manual testing with Commerce Demo app and Griffon

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested a review from kevinlind July 17, 2020 22:24
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 20, 2020

Codecov Report

Merging #51 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #51   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files          29       29           
  Lines         981      981           
=======================================
  Hits          766      766           
  Misses        215      215           

@emdobrin
Copy link
Copy Markdown
Contributor Author

@kevinlind I merged dev into this branch and it applied a bunch of formatting changes, let me know if it looks ok to you too.

@kevinlind kevinlind merged commit 62b8d05 into adobe:dev Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants