Update recoverable error codes#492
Merged
emdobrin merged 6 commits intoadobe:hotfix-v5.0.3from Oct 14, 2024
Merged
Conversation
praveek
reviewed
Oct 8, 2024
sbenedicadb
approved these changes
Oct 9, 2024
Member
sbenedicadb
left a comment
There was a problem hiding this comment.
good pending decision on whether a retry-after value of 0 is valid or not
kevinlind
approved these changes
Oct 9, 2024
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Looks good, pending change suggested by Praveen.
praveek
reviewed
Oct 14, 2024
| test-ios: | ||
| macos: | ||
| xcode: 15.1.0 # Specify the Xcode version to use | ||
| resource_class: macos.x86.medium.gen2 |
There was a problem hiding this comment.
nit: We don't specify resource_class for our other repos and let circle ci choose the default one. I’d recommend removing it if it’s not necessary.
Contributor
There was a problem hiding this comment.
The Edge functional tests were at times using 100% of the default image CPU causing test failures. We specify the medium resource class to provide more CPU power for these tests.
praveek
approved these changes
Oct 14, 2024
Contributor
Author
|
@sbenedicadb, I confirmed that retry-after with value 0 is not expected from server-side so I kept the changes, ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: