Skip to content

update weak self usage#474

Merged
emdobrin merged 2 commits intoadobe:devfrom
emdobrin:dev2
May 24, 2024
Merged

update weak self usage#474
emdobrin merged 2 commits intoadobe:devfrom
emdobrin:dev2

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

Allow closure from hit queue to execute if still available, passing down to the parent of this closure - this change should not make a difference as the persistent hit queue holds a strong reference to hit processor and queue, so both should still be available for processing.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested review from addb, kevinlind and praveek May 24, 2024 21:09
@emdobrin emdobrin merged commit ed541ac into adobe:dev May 24, 2024
@emdobrin emdobrin deleted the dev2 branch May 24, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants