Wait for Configuration update in Integration tests#462
Merged
Conversation
timkimadobe
approved these changes
May 1, 2024
Contributor
timkimadobe
left a comment
There was a problem hiding this comment.
Thanks for the test case updates Kevin! Changes look good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes failures in
UpstreamIntegrationTests.testSendEvent_withInvalidDatastreamID_receivesExpectedError()due toupdateConfigurationWith(config:)not being processed fast enough. The issue is since the integration tests perform a remote download of their configuration during setup, thesendEventcall in the test case gets dispatched before the initial Configuration state is set. In the failing test case, a second Configuration update is made to set an invalidedge.configId, however it is processed after the experience event is queued. Recent updates now set the configuration with the queued experience event, instead of resolving the configuration at the time the event is processed.The fix is to wait for the Configuration response content event during setup before starting each test case.
Updates calls to
assertExactMatchandassertTypeMatchto usepathOptions, as the old APIs are deprecated.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: