Skip to content

[DEV] Fixed intermittent functional test failure on shared state events count#45

Merged
kevinlind merged 1 commit intoadobe:devfrom
emdobrin:dev
Jul 10, 2020
Merged

[DEV] Fixed intermittent functional test failure on shared state events count#45
kevinlind merged 1 commit intoadobe:devfrom
emdobrin:dev

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

  • Moved ACPCore.start in the functional test class after all the extensions are registered.
  • Remove overridden config and data from swift datastore between tests

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested a review from kevinlind July 10, 2020 20:38
@kevinlind kevinlind merged commit 1b6d01c into adobe:dev Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants