Merged
Conversation
kevinlind
reviewed
Feb 20, 2024
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Looks good. One small change.
cacheung
reviewed
Feb 21, 2024
.circleci/config.yml
Outdated
| platform: "iOS" | ||
| version: "16.1" | ||
| version: "17.0" | ||
| device: "iPhone 14" |
Contributor
There was a problem hiding this comment.
are we updating codecov to 3.3.0 for Edge?
Contributor
Author
There was a problem hiding this comment.
I am seeing some issues with the codecov org and this macos/xcode version, and I am trying to confirm if these is a workaround with the Codecov team. we'll take any changes regarding codecov in a separate PR.
cacheung
approved these changes
Feb 21, 2024
kevinlind
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates minimum supported iOS, tvOS to 12.0
Fixes podspec verification failure
CircleCI, workflow Xcode updates
Readme updates
Note: If adobe/aepsdk-edgeidentity-ios#117 is merged beforehand, I can update that dependency to dev-v5.0.0 also
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: