Refactor integration tests to use JSON comparison#439
Merged
timkimadobe merged 6 commits intoadobe:devfrom Jan 31, 2024
Merged
Conversation
…ntHandle to be able to strictly validate collection counts Update formatting, removing raw strings where not required
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #439 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 27 27
Lines 1730 1730
=======================================
Hits 1669 1669
Misses 61 61 |
emdobrin
reviewed
Jan 12, 2024
timkimadobe
commented
Jan 27, 2024
Contributor
Author
timkimadobe
left a comment
There was a problem hiding this comment.
Thanks for the review @emdobrin! Updated based on feedback
emdobrin
approved these changes
Jan 27, 2024
Contributor
|
Looks good to me, make sure you rebase over dev changes before merging |
kevinlind
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the integration tests to use the latest features from the JSON comparison tool in AEPTestUtils. Specifically:
testSendEvent_with_NO_priorState_receivesExpectedStateStoreEventHandleis updated to strictly validate collection sizes (which was not possible beforepathOptionswas available)Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: