Add cron schedule to integration test job#423
Merged
timkimadobe merged 2 commits intoadobe:devfrom Oct 17, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #423 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 27 27
Lines 1672 1672
=======================================
Hits 1618 1618
Misses 54 54 |
kevinlind
approved these changes
Oct 17, 2023
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Remove the unneeded comment, otherwise looks good.
Comment on lines
+13
to
+14
| # Run every weekday at 12:16 PM PST (Standard time) -> 8:16 PM UTC | ||
| # - cron: '16 20 * * 1-5' |
Contributor
There was a problem hiding this comment.
Can you remove this comment?
Contributor
Author
There was a problem hiding this comment.
Removed! Thanks Kevin
Update doc to mention how to convert back to PST
timkimadobe
commented
Oct 17, 2023
Contributor
Author
timkimadobe
left a comment
There was a problem hiding this comment.
Thanks for the review @kevinlind! Updated based on feedback
Comment on lines
+13
to
+14
| # Run every weekday at 12:16 PM PST (Standard time) -> 8:16 PM UTC | ||
| # - cron: '16 20 * * 1-5' |
Contributor
Author
There was a problem hiding this comment.
Removed! Thanks Kevin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a cron schedule to the integration test GitHub Action workflow. The job will use default values for workflow inputs, meaning it will test the following configuration:
The current schedule runs at 12:16pm every weekday (MON-FRI) taking into account the following considerations:
Given that runners operate in UTC, the cron times have been adjusted for PDT (PST with daylight savings applied) and PST, with the PDT version currently active since we are in daylight savings time.
After review of this PR, will open similar on the Android side.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: