Skip to content

Add cron schedule to integration test job#423

Merged
timkimadobe merged 2 commits intoadobe:devfrom
timkimadobe:integration-test-cron-schedule
Oct 17, 2023
Merged

Add cron schedule to integration test job#423
timkimadobe merged 2 commits intoadobe:devfrom
timkimadobe:integration-test-cron-schedule

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe commented Oct 16, 2023

Description

This PR adds a cron schedule to the integration test GitHub Action workflow. The job will use default values for workflow inputs, meaning it will test the following configuration:

  1. prod Edge extension
  2. prod Edge Network
  3. no prior location hint set for test cases

The current schedule runs at 12:16pm every weekday (MON-FRI) taking into account the following considerations:

  1. Easier to check run results during normal work hours (post-lunch, and most of the run is during lunch)
    • Note: runs are currently taking ~5mins to complete
  2. Currently the test runs are non-critical for reporting, so running during these times will avoid sending alerts/emails to subscribers during non-work hours
  3. An uncommon minute slot was picked to avoid peak runner schedule times (ex: top of the hour, probably also 15 and 10 min intervals), and reduce the chance of the job being dropped (see the Note box for schedule)
  4. Not sure when this PR will be merged, so don't want to miss the cron being triggered within the week by picking the wrong day

Given that runners operate in UTC, the cron times have been adjusted for PDT (PST with daylight savings applied) and PST, with the PDT version currently active since we are in daylight savings time.

After review of this PR, will open similar on the Android side.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe linked an issue Oct 16, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2023

Codecov Report

Merging #423 (d1a9371) into dev (2aed8e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #423   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          27       27           
  Lines        1672     1672           
=======================================
  Hits         1618     1618           
  Misses         54       54           

Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unneeded comment, otherwise looks good.

Comment on lines +13 to +14
# Run every weekday at 12:16 PM PST (Standard time) -> 8:16 PM UTC
# - cron: '16 20 * * 1-5'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this comment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed! Thanks Kevin

Update doc to mention how to convert back to PST
Copy link
Copy Markdown
Contributor Author

@timkimadobe timkimadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @kevinlind! Updated based on feedback

Comment on lines +13 to +14
# Run every weekday at 12:16 PM PST (Standard time) -> 8:16 PM UTC
# - cron: '16 20 * * 1-5'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed! Thanks Kevin

@timkimadobe timkimadobe merged commit 8ecf67e into adobe:dev Oct 17, 2023
@timkimadobe timkimadobe deleted the integration-test-cron-schedule branch October 17, 2023 21:56
@emdobrin emdobrin added this to the v4.3.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update integration test workflow for resilience

3 participants