Test helper parity and method renaming#405
Merged
timkimadobe merged 7 commits intoadobe:devfrom Sep 27, 2023
Merged
Conversation
# Conflicts: # Tests/TestUtils/MockNetworkService.swift # Tests/TestUtils/NetworkRequestHelper.swift # Tests/TestUtils/RealNetworkService.swift # Tests/UpstreamIntegrationTests/UpstreamIntegrationTests.swift
Rename setExpectationForNetworkRequest to be more Swifty # Conflicts: # Tests/TestUtils/MockNetworkService.swift
Rename timeout to expectationTimeout to clarify timeout intent Refactor logic to remove waiting in getResponses, and rely on await in assertAllNetworkRequestExpectations # Conflicts: # Tests/TestUtils/MockNetworkService.swift # Tests/TestUtils/NetworkRequestHelper.swift # Tests/TestUtils/RealNetworkService.swift # Tests/UpstreamIntegrationTests/UpstreamIntegrationTests.swift
Update method documentation
Codecov Report
@@ Coverage Diff @@
## dev #405 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 27 27
Lines 1671 1671
=======================================
Hits 1617 1617
Misses 54 54 |
10 tasks
emdobrin
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
RealNetworkServicegetResponsemethod to not include an await in the logic, instead returning results immediately, and relying onassertAllNetworkRequestExpectationsto perform awaitsMock/RealNetworkService, a lot of the redundant networkRequest method and param names can probably be omitted without affecting clarity of intent.MockNetworkService
getMockResponseFor(networkRequest:)getMockResponse(for:)setMockResponseFor(networkRequest:responseConnection:)setMockResponse(for:responseConnection:)setMockResponseFor(url:httpMethod:responseConnection:)setMockResponse(url:httpMethod:responseConnection:)NetworkRequestHelper
getSentNetworkRequestsMatching(networkRequest:)getSentRequests(matching:)setResponseFor(networkRequest:responseConnection:)setResponse(for:responseConnection:)getResponseFor(networkRequest:)getResponse(for:)setExpectationForNetworkRequest(networkRequest:...)setExpectation(for:...)timeoutexpectationTimeoutgetNetworkRequestsWithandawaitRequestparametertimeout->expectationTimeout(as this timeout only applies if there is already an expectation set on the network request, if there is no expectation this timeout value is not used and the default timeout is used instead)RealNetworkService
getResponseFor(networkRequest:timeout:)getResponse(for:)setExpectationForNetworkRequest(networkRequest:...)setExpectation(for:...)Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: