Replace hardcoded event source with EventSource.contentComplete#388
Merged
Replace hardcoded event source with EventSource.contentComplete#388
Conversation
Update Podfile.lock with latest Core version
Codecov Report
@@ Coverage Diff @@
## dev #388 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 27 27
Lines 1671 1671
=======================================
Hits 1617 1617
Misses 54 54 |
emdobrin
reviewed
Aug 31, 2023
| name: EdgeConstants.EventName.CONTENT_COMPLETE, | ||
| type: EventType.edge, | ||
| source: "com.adobe.eventSource.contentComplete", // TODO replace with EventSource constant | ||
| source: EventSource.contentComplete, |
Contributor
There was a problem hiding this comment.
For code dependencies on Core we need to also update min version in podspec and Package.swift
Contributor
Author
There was a problem hiding this comment.
Thank you, updated!
kevinlind
approved these changes
Aug 31, 2023
emdobrin
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: