Skip to content

Fix integration test setup to properly wait and clear expectations#387

Merged
emdobrin merged 1 commit intoadobe:devfrom
timkimadobe:fix-integration-test-case
Aug 31, 2023
Merged

Fix integration test setup to properly wait and clear expectations#387
emdobrin merged 1 commit intoadobe:devfrom
timkimadobe:fix-integration-test-case

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe commented Aug 30, 2023

Description

This PR fixes a test issue where the setup event and response was not being cleaned up properly, and causing unexpected location hints to be set.

The fix adds an expected event handle and waits for it in the test case setup before continuing with the main test case logic.

Related Issue

MOB-19330

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2023

Codecov Report

Merging #387 (87569cb) into dev (3963826) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #387   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          27       27           
  Lines        1671     1671           
=======================================
  Hits         1617     1617           
  Misses         54       54           

@emdobrin emdobrin merged commit b168a06 into adobe:dev Aug 31, 2023
@timkimadobe timkimadobe deleted the fix-integration-test-case branch August 31, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants