[CI] Sleep after EventHub.shared.start in API unit tests#369
Merged
[CI] Sleep after EventHub.shared.start in API unit tests#369
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #369 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 27 27
Lines 1653 1653
=======================================
Hits 1599 1599
Misses 54 54 |
emdobrin
approved these changes
Jul 17, 2023
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Change looks good, but as a future enhancement for testing can we can get notified on start completion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Seeing test failures running EdgePublicAPITests unit test suite. Tests fail with an AEPError of timeout without executing test listener logic. It appears the MobileCore.registerEventListener call in the test cases is failing because the EventHub has not completed start up. Adding a short sleep after calling
EventHub.shared.startgives the EventHub more time to startup before the tests execute.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: