Get 'eventIndex' from 'report' object for interact response errors and warnings#363
Merged
Get 'eventIndex' from 'report' object for interact response errors and warnings#363
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## dev #363 +/- ##
==========================================
+ Coverage 96.70% 96.73% +0.04%
==========================================
Files 27 27
Lines 1634 1653 +19
==========================================
+ Hits 1580 1599 +19
Misses 54 54 |
emdobrin
reviewed
Jul 11, 2023
Contributor
|
Based on this description I think we should also add integration tests that verify the expected format for each with the real endpoint, as well as asserting no unexpected keys are added in the handle body. We can take this in a separate PR as is depends on the integration tests feature branch. cc @timkimadobe |
emdobrin
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Network responses for interact requests set the 'eventIndex' field under the 'report' object for errors and warnings and not the root error/warning object where Edge is currently looking. This change moves the 'eventIndex' field from EdgeEventError to EdgeErrorReport and from EdgeEventWarning to EdgeEventWarningReport objects. A successful response handle sets the "eventIndex" under the root of EdgeEventHandle, so no change to that logic was made.
Below is an example of an interact network response, showing the location of the "eventIndex" in each of the 'handle', 'error', and 'warning' response objects.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: