Skip to content

Fix makefile build-app command#356

Merged
addb merged 2 commits intoadobe:mainfrom
addb:make
Jun 2, 2023
Merged

Fix makefile build-app command#356
addb merged 2 commits intoadobe:mainfrom
addb:make

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Jun 2, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested review from emdobrin and kevinlind June 2, 2023 01:35
@addb addb changed the title Fix makefile buil-app command Fix makefile build-app command Jun 2, 2023
@addb addb requested a review from cacheung June 2, 2023 01:41
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #356 (037bef9) into main (edd35fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          27       27           
  Lines        1626     1626           
=======================================
  Hits         1572     1572           
  Misses         54       54

@addb addb merged commit 07bb964 into adobe:main Jun 2, 2023
@addb addb deleted the make branch June 2, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emdobrin emdobrin emdobrin approved these changes

@kevinlind kevinlind Awaiting requested review from kevinlind

@cacheung cacheung Awaiting requested review from cacheung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@addb @emdobrin