Skip to content

Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 4.0.0#344

Merged
kevinlind merged 20 commits intoadobe:devfrom
addb:xcode
Jun 1, 2023
Merged

Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 4.0.0#344
kevinlind merged 20 commits intoadobe:devfrom
addb:xcode

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented May 17, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #344 (a7b9f5b) into dev (7f530ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #344   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          27       27           
  Lines        1626     1626           
=======================================
  Hits         1572     1572           
  Misses         54       54

@addb addb requested review from cdhoffmann, kevinlind and praveek May 18, 2023 00:09
@addb addb requested a review from emdobrin May 18, 2023 22:50
@addb addb added the DO NOT MERGE Label to apply to PRs that should not be merged for whatever reason label May 19, 2023
@addb addb marked this pull request as ready for review May 19, 2023 19:37
kevinlind
kevinlind reviewed May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the CircleCI configuration config.yml to use xcode version 14.1.0 (from "13.4.0") plus update the simulators to specify version "16.1".

  prestart_ios_simulator:
    steps:
      - macos/preboot-simulator:
          platform: "iOS"
          version: "16.1"
          device: "iPhone 14"

  prestart_tvos_simulator:
    steps:
      - macos/preboot-simulator:
          platform: "tvOS"
          version: "16.1"
          device: "Apple TV"

cacheung
cacheung reviewed May 30, 2023
View reviewed changes
@cacheung
Copy link
Copy Markdown
Contributor

cacheung commented May 30, 2023

Need to update for test-SPM.sh version
https://github.com/addb/aepsdk-edge-ios/blob/xcode/Script/test-SPM.sh#L23

praveek
praveek reviewed May 31, 2023
View reviewed changes
@emdobrin emdobrin removed the DO NOT MERGE Label to apply to PRs that should not be merged for whatever reason label May 31, 2023
kevinlind
kevinlind reviewed May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the versions in the SPM instructions in the getting-started guide?
https://github.com/adobe/aepsdk-edge-ios/blob/dev/Documentation/getting-started.md#download-the-edge-extension

@addb addb requested review from cacheung, kevinlind and praveek May 31, 2023 06:23
@cacheung
Copy link
Copy Markdown
Contributor

cacheung commented May 31, 2023

Under Readme file
Command line integration section, it mentions to use "make test". There is no test action in make file.

@addb addb requested a review from kevinlind May 31, 2023 20:08
@addb addb changed the title Update Min supported version to iOS 11 and tvOS 11 Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 2.0.0 May 31, 2023
@emdobrin emdobrin changed the title Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 2.0.0 Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 4.0.0 May 31, 2023
kevinlind
kevinlind reviewed Jun 1, 2023
View reviewed changes
@addb addb requested a review from kevinlind June 1, 2023 00:47
@kevinlind kevinlind merged commit 3a9d273 into adobe:dev Jun 1, 2023
@addb addb deleted the xcode branch June 1, 2023 17:30
@emdobrin emdobrin added this to the v4.0.0 milestone Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cacheung cacheung cacheung approved these changes

@kevinlind kevinlind kevinlind approved these changes

@cdhoffmann cdhoffmann Awaiting requested review from cdhoffmann

@emdobrin emdobrin Awaiting requested review from emdobrin

@praveek praveek Awaiting requested review from praveek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@addb @cacheung @praveek @kevinlind @emdobrin