Skip to content

Allow empty 'payload' field in response handle event (resolves #316)#322

Merged
kevinlind merged 2 commits intoadobe:devfrom
kevinlind:empty-payload
Mar 30, 2023
Merged

Allow empty 'payload' field in response handle event (resolves #316)#322
kevinlind merged 2 commits intoadobe:devfrom
kevinlind:empty-payload

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind commented Mar 29, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kevinlind kevinlind linked an issue Mar 29, 2023 that may be closed by this pull request
Payload field is missing in response handle when it is an empty array #316
Closed
3 tasks
@kevinlind kevinlind requested a review from emdobrin March 29, 2023 22:47
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #322 (2916630) into dev (079595c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #322      +/-   ##
==========================================
+ Coverage   96.54%   96.61%   +0.06%     
==========================================
  Files          28       28              
  Lines        1649     1650       +1     
==========================================
+ Hits         1592     1594       +2     
+ Misses         57       56       -1

emdobrin
emdobrin reviewed Mar 29, 2023
View reviewed changes
@kevinlind kevinlind merged commit 14ae9c2 into adobe:dev Mar 30, 2023
@kevinlind kevinlind deleted the empty-payload branch March 30, 2023 18:42
@emdobrin emdobrin added this to the v1.6.1 milestone Mar 30, 2023
@emdobrin emdobrin modified the milestones: v4.0.1, v4.0.0 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emdobrin emdobrin emdobrin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Payload field is missing in response handle when it is an empty array

2 participants

@kevinlind @emdobrin