[AMSDK-9837] Support multi-datasets for ExperiencePlatformEvents#31
Conversation
…ts and doc updates
Codecov Report
@@ Coverage Diff @@
## feature/datasetIdOverride #31 +/- ##
=============================================================
+ Coverage 71.34% 71.53% +0.19%
=============================================================
Files 29 29
Lines 949 959 +10
=============================================================
+ Hits 677 686 +9
- Misses 272 273 +1 |
kevinlind
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments.
| class ExperiencePlatformEventTests: XCTestCase { | ||
| private let DATASET_ID = "datasetId" | ||
| private let XDM = "xdm" | ||
| private let DATA = "data" |
There was a problem hiding this comment.
[nit: style] We will need to agree on a style guide for Swift so this is up for discussion, but I think in general lower camel-case is used for all variables, even constants.
https://google.github.io/swift/#global-constants
https://swift.org/documentation/api-design-guidelines/#general-conventions
There was a problem hiding this comment.
I know.. I can change them for now and let's discuss about this more. I personally don't like the lower cased version because it's really difficult to differentiate them from other properties.
nporter-adbe
left a comment
There was a problem hiding this comment.
Looks good, most of my comments were similar to @kevinlind
Description
Support multi-datasets for ExperiencePlatform events
Related Issue
The e2e flow fails with the following error:
240 - Validation An error occurred while processing the batch. Please contact support. Schema for the datasetId from catalog does not match the message; pointer to violation:
Requires this task for completion - EXEG-1745.
Motivation and Context
See Spec https://wiki.corp.adobe.com/display/adms/Dataset+ID+override+per+event
How Has This Been Tested?
Unit tests and manual test with Data Platform
Screenshots (if appropriate):
Types of changes
Checklist: