[MOB-17169] Add Get/Set APIs for Location Hint#271
Merged
Conversation
kevinlind
commented
Sep 19, 2022
| sleep(1) | ||
| } | ||
|
|
||
| func testSetLocationHint_valueHint_dispatchesEdgeUpdateProperty() { |
Contributor
Author
There was a problem hiding this comment.
I moved these test cases from the Functional test suite to the Unit Test suite. All the above code is the same as before and the below tests are new for setLocationHint and getLocationHint.
kevinlind
commented
Sep 19, 2022
| import AEPServices | ||
| import XCTest | ||
|
|
||
| class EdgePublicAPITests: FunctionalTestBase { |
Contributor
Author
There was a problem hiding this comment.
This is a new file with new functional tests. The "deleted" file EdgePublicAPITests I moved from the FunctionalTests folder to the UnitTests folder.
addb
reviewed
Sep 19, 2022
addb
reviewed
Sep 19, 2022
addb
reviewed
Sep 19, 2022
addb
reviewed
Sep 19, 2022
addb
reviewed
Sep 19, 2022
Contributor
addb
left a comment
There was a problem hiding this comment.
Left few nit comments. Looks good overall!
Codecov Report
@@ Coverage Diff @@
## dev #271 +/- ##
==========================================
+ Coverage 95.45% 95.50% +0.05%
==========================================
Files 28 28
Lines 1143 1045 -98
==========================================
- Hits 1091 998 -93
+ Misses 52 47 -5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds getLocationHint and setLocationHint APIs to Edge+PublicAPI.
The getLocationHint API retrieves the current stored location hint value or nil if the location hint is not set or is expired.
The setLocationHint API sets the given location hint. The setter also allows nil/empty values which clears the currently stored location hint value.
Podfile updated to use AEPCore from GitHub branch dev-v3.7.1, as new EventSource values are needed by Edge. Will need to release Core v3.7.1 before releasing these changes to Edge.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: