Skip to content

Renaming to TestApps/TestAppSwiftUI#247

Merged
emdobrin merged 8 commits intoadobe:devfrom
emdobrin:cleanupTestApp
May 10, 2022
Merged

Renaming to TestApps/TestAppSwiftUI#247
emdobrin merged 8 commits intoadobe:devfrom
emdobrin:cleanupTestApp

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

@emdobrin emdobrin commented May 7, 2022 •
edited
Loading

Description

  • Renamed test apps folder to TestApps
  • Renamed test app to TestAppSwiftUI
  • Updated CircleCI Xcode version to 12.0.1

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin added the tooling Tooling updates and CI/CD improvements label May 7, 2022
@emdobrin emdobrin requested review from addb and kevinlind May 7, 2022 01:05
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2022 •
edited
Loading

Codecov Report

Merging #247 (d143892) into dev (b6282d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #247   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          27       27           
  Lines         998      998           
=======================================
  Hits          944      944           
  Misses         54       54

@cacheung cacheung self-requested a review May 9, 2022 23:26
cacheung
cacheung approved these changes May 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cacheung cacheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to run TestApp_SwiftUI.

kevinlind
kevinlind approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, however I would prefer the name TestAppSwiftUI, without the underscore. Just a personal preference.

@emdobrin emdobrin changed the title Renaming to TestApps/TestApp_SwiftUI Renaming to TestApps/TestAppSwiftUI May 10, 2022
kevinlind
kevinlind reviewed May 10, 2022
View reviewed changes
.circleci/config.yml
build-and-test:
macos:
xcode: 11.6.0 # Specify the Xcode version to use
xcode: 12.0.1 # Specify the Xcode version to use
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the iOS simulator version as well. It looks like "iPhone 8 (13.5)" is a valid simulator in the 12.0.1 image.
Here's the AEPAudience CircleCI build which lists the simulators for the 12.0.1 image:
https://app.circleci.com/pipelines/github/adobe/aepsdk-audience-ios/218/workflows/23e1af05-5c85-4455-97ab-845dbdefc192/jobs/225?invite=true#step-111-74

kevinlind
kevinlind approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a comment about updating the CircleCI configuration with a valid simulator version.

@emdobrin emdobrin merged commit 7833888 into adobe:dev May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cacheung cacheung cacheung approved these changes

@kevinlind kevinlind kevinlind approved these changes

@addb addb Awaiting requested review from addb

Assignees

No one assigned

Labels

tooling Tooling updates and CI/CD improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emdobrin @cacheung @kevinlind