Merge dev -> feature/adidConsent#246
Merged
emdobrin merged 2 commits intoadobe:feature/adidConsentfrom May 9, 2022
Merged
Conversation
…adobe#245) * [DEV] Updates on EdgeEndpoint, renaming, clean up unused fields [DEV] Renaming EdgeRequestType, environmentType [DEV] Build edge url with components [DEV] EdgeEndpoint cleanup [DEV] Updated tests for impl changes, compacting EdgeEndpointTests [DEV] Cleanup, docs [DEV] Fix typo * [DEV] Remove unused hit getType, fix comment * Run all tests in foreach * Fix param name in comment * [DEV] Rename edgeEndpoint to endpoint * Renaming to buildEdgeEndpoint
Codecov Report
@@ Coverage Diff @@
## feature/adidConsent #246 +/- ##
=======================================================
+ Coverage 94.52% 94.59% +0.07%
=======================================================
Files 27 27
Lines 985 998 +13
=======================================================
+ Hits 931 944 +13
Misses 54 54 |
cacheung
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: