Skip to content

Remove commerce test app#244

Merged
emdobrin merged 3 commits intoadobe:devfrom
emdobrin:remove-commerce-app
Apr 18, 2022
Merged

Remove commerce test app#244
emdobrin merged 3 commits intoadobe:devfrom
emdobrin:remove-commerce-app

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

Removes all source code for commerce test app, keeping only the AEPSampleAppSwiftUI for testing purposes in this repo. The commerce examples are now available at https://github.com/adobe/aepsdk-sample-app-ios/tree/main/Swift/AEPSampleApp

Related Issue

Motivation and Context

Reduce code duplication and maintenance

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin requested a review from kevinlind April 14, 2022 23:58
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2022

Codecov Report

Merging #244 (a358526) into dev (f0e978d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #244   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          27       27           
  Lines         979      979           
=======================================
  Hits          925      925           
  Misses         54       54           

Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we must remove it, I'm sad to see it go 😢

@emdobrin
Copy link
Copy Markdown
Contributor Author

I know, I loved purchasing colors 😢

@emdobrin emdobrin merged commit fe251fe into adobe:dev Apr 18, 2022
@emdobrin emdobrin deleted the remove-commerce-app branch April 18, 2022 18:43
@emdobrin emdobrin linked an issue Apr 20, 2022 that may be closed by this pull request
@emdobrin emdobrin added the tooling Tooling updates and CI/CD improvements label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Tooling updates and CI/CD improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove commerce app and update doc to point to sample app

2 participants