Skip to content

Add query operation update to consent requests#243

Merged
emdobrin merged 4 commits intoadobe:feature/adidConsentfrom
emdobrin:MOB-15907
Apr 22, 2022
Merged

Add query operation update to consent requests#243
emdobrin merged 4 commits intoadobe:feature/adidConsentfrom
emdobrin:MOB-15907

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

Description

MOB-15907 - Adds query operation update setting to all consent requests in preparation for incremental updates for adid consent.

Related Issue

Motivation and Context

The query option is required to overwrite the default behavior in Edge Network where collect consent is required with the consent preferences. This allows for other consent preferences to be collected earlier in the application lifecycle, while the default collect settings may be used.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm not finding any faults with this.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2022

Codecov Report

Merging #243 (1639757) into dev (f0e978d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #243      +/-   ##
==========================================
+ Coverage   94.48%   94.52%   +0.03%     
==========================================
  Files          27       27              
  Lines         979      985       +6     
==========================================
+ Hits          925      931       +6     
  Misses         54       54              

@emdobrin
Copy link
Copy Markdown
Contributor Author

@kevinlind thanks for reviewing.
The build was failing and I made a small change - reverted the pod updates. It looks like the latest AEPEdgeConsent brings AEPEdge as a dependency and once installed it shows as a new scheme in Xcode so the xcodebuild gets confused to which one to pick.
We have couple options for this:

  • We clean up the test apps and tests in this repo to not bring external dependencies other than AEPCore so we can continue using AEPEdge from source code. Any integration tests with Consent + Edge will be moved to Consent extension. Any manual integration tests will be executed using the sample app.
  • We define a test podspec for AEPEdgeConsent and exclude the AEPEdge dependency so we can continue using it.

I am inclined towards the first one, let me know your thoughts.

@kevinlind
Copy link
Copy Markdown
Contributor

@kevinlind thanks for reviewing. The build was failing and I made a small change - reverted the pod updates. It looks like the latest AEPEdgeConsent brings AEPEdge as a dependency and once installed it shows as a new scheme in Xcode so the xcodebuild gets confused to which one to pick. We have couple options for this:

  • We clean up the test apps and tests in this repo to not bring external dependencies other than AEPCore so we can continue using AEPEdge from source code. Any integration tests with Consent + Edge will be moved to Consent extension. Any manual integration tests will be executed using the sample app.
  • We define a test podspec for AEPEdgeConsent and exclude the AEPEdge dependency so we can continue using it.

I am inclined towards the first one, let me know your thoughts.

I'm inclined to the first option as well. However, I'd like to know more about change adobe/aepsdk-edgeconsent-ios#43 to see if we can simply remove the AEPEdge dependency from the AEPEdgeConsent podspec.

@emdobrin
Copy link
Copy Markdown
Contributor Author

Even though there is no hard dependency on the Edge extension APIs, the Consent extension relies on the Edge functionality for handling the consent updates. Any new feature or improvement to support the Consent workflows will require a bump in this dependency, and I think the dependency link is still required for better version management.
I created a new task for the clean-up.

@emdobrin emdobrin changed the base branch from dev to feature/adidConsent April 22, 2022 16:07
@emdobrin emdobrin merged commit a5365f7 into adobe:feature/adidConsent Apr 22, 2022
@emdobrin emdobrin deleted the MOB-15907 branch April 22, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants