Skip to content

Use edge.domain directly if set, without 'cleaning'#231

Merged
kevinlind merged 1 commit intoadobe:devfrom
kevinlind:remove-endpoint-clean
Jan 19, 2022
Merged

Use edge.domain directly if set, without 'cleaning'#231
kevinlind merged 1 commit intoadobe:devfrom
kevinlind:remove-endpoint-clean

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

Description

Use 'edge.domain' configuration as set by user, if available. Do not attempt to "clean" domain string.

internal ticket: part of MOB-14959

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kevinlind kevinlind requested a review from emdobrin January 19, 2022 19:57
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2022

Codecov Report

Merging #231 (008e01f) into dev (c90baf1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #231      +/-   ##
==========================================
- Coverage   94.51%   94.48%   -0.02%     
==========================================
  Files          27       27              
  Lines         983      979       -4     
==========================================
- Hits          929      925       -4     
  Misses         54       54              

@kevinlind kevinlind merged commit 00be6b4 into adobe:dev Jan 19, 2022
@kevinlind kevinlind deleted the remove-endpoint-clean branch January 19, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants