Skip to content

Update build scripts to fix the build archive step.#220

Merged
emdobrin merged 4 commits intoadobe:devfrom
addb:buildScriptFixes
Dec 17, 2021
Merged

Update build scripts to fix the build archive step.#220
emdobrin merged 4 commits intoadobe:devfrom
addb:buildScriptFixes

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Dec 3, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested review from emdobrin and kevinlind December 3, 2021 08:37
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 3, 2021

Codecov Report

Merging #220 (a00e7e8) into dev (8cf1db1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #220   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          26       26           
  Lines         923      923           
=======================================
  Hits          871      871           
  Misses         52       52           

Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the SwiftLint path in the Git Hook, https://github.com/adobe/aepsdk-edge-ios/blob/main/.githooks/pre-commit#L2

@addb addb requested review from cdhoffmann and removed request for cdhoffmann December 17, 2021 01:47
@emdobrin emdobrin merged commit 562bd83 into adobe:dev Dec 17, 2021
@emdobrin emdobrin added the tooling Tooling updates and CI/CD improvements label Jan 6, 2022
@addb addb deleted the buildScriptFixes branch September 5, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Tooling updates and CI/CD improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants