Attach ImplementationDetails to XDM payload for each request#219
Merged
Attach ImplementationDetails to XDM payload for each request#219
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #219 +/- ##
==========================================
+ Coverage 94.37% 94.45% +0.08%
==========================================
Files 26 27 +1
Lines 923 973 +50
==========================================
+ Hits 871 919 +48
- Misses 52 54 +2 |
…e, use 'unknown' in Implementation Details
emdobrin
reviewed
Dec 2, 2021
Contributor
|
@kevinlind can you please update the spec with an edge case section and provide an example for unknown? |
…per name in separate function.
emdobrin
reviewed
Dec 14, 2021
10 tasks
emdobrin
reviewed
Dec 15, 2021
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
looks good with a threading comment
…cross multiple threads.
emdobrin
approved these changes
Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attaches ImplementationDetails to the XDM payload of each Experience Event.
See: XDM ImplementationDetails schema
internal ticket: MOB-15365
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: