Conform generic network errors to EdgeEventError type#217
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #217 +/- ##
==========================================
+ Coverage 94.30% 94.37% +0.06%
==========================================
Files 26 26
Lines 913 923 +10
==========================================
+ Hits 861 871 +10
Misses 52 52 |
kevinlind
commented
Oct 15, 2021
| dispatchEventErrors(errorsArray: edgeResponse.errors, requestId: requestId) | ||
| } else if let edgeErrorResponse = try? JSONDecoder().decode(EdgeEventError.self, from: data) { | ||
| // generic server error, return the error as is | ||
| Log.warning(label: LOG_TAG, |
Contributor
Author
There was a problem hiding this comment.
I removed this log message because it is redundant with the message on line 120.
emdobrin
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generic network errors generated by the EdgeNetworkService would fail to be handled by the NetworkResponseHandler as they failed to encode to type EdgeEventError. This fix changes the generic network errors to conform to EdgeEventError so they are correctly handled and dispatched.
Related Issue
MOB-14451
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: