Remove sample app validation step from CI#214
Merged
emdobrin merged 4 commits intoadobe:stagingfrom Sep 2, 2021
Merged
Conversation
Removing as Assurance v3 requires Xcode 12 to build.
emdobrin
reviewed
Sep 2, 2021
Comment on lines
-100
to
-106
| # verify demo app builds | ||
| - run: | ||
| name: Build Demo App | ||
| command: | | ||
| if [ "${CIRCLE_BRANCH}" == "main" ]; then | ||
| make build-app | ||
| fi |
Contributor
There was a problem hiding this comment.
Should we keep this code around and comment it out until we get it fixed?
Contributor
Author
There was a problem hiding this comment.
As it's in source control we have access to the code if needed. I'd prefer to keep it clean and remove the code.
Codecov Report
@@ Coverage Diff @@
## staging #214 +/- ##
========================================
Coverage 94.30% 94.30%
========================================
Files 26 26
Lines 913 913
========================================
Hits 861 861
Misses 52 52 |
emdobrin
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove sample app validation step from CI. Sample app uses Assurance v3 which currently can only be built with Xcode 12.
Run XCFramework validation step on 'main' and 'staging' branches in CI.
Remove unused ACPCore from AEPCommerceDemoApp Podfile.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: