Skip to content

Skip lint build phase when flag is present.#207

Merged
kevinlind merged 2 commits intoadobe:devfrom
kevinlind:skip-lint
Jul 30, 2021
Merged

Skip lint build phase when flag is present.#207
kevinlind merged 2 commits intoadobe:devfrom
kevinlind:skip-lint

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

Description

Add ability to skip the lint build phase. This options cleans up building in CI as the CI configuration includes a separate CI step to lint the entire project. The flag eliminates the duplicate lint build phases when building each target.

Skip the SwiftLint build phase for each target when variable ADB_SKIP_LINT=YES.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kevinlind kevinlind requested a review from emdobrin July 29, 2021 21:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2021

Codecov Report

Merging #207 (38437fa) into dev (ab5699f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #207   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files          26       26           
  Lines         913      913           
=======================================
  Hits          861      861           
  Misses         52       52           

@kevinlind kevinlind merged commit 46de111 into adobe:dev Jul 30, 2021
@kevinlind kevinlind deleted the skip-lint branch July 30, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants