lint autocorrect and changes from main#206
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #206 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 26 26
Lines 913 913
=======================================
Hits 861 861
Misses 52 52 |
kevinlind
reviewed
Jul 29, 2021
|
|
||
| lint-autocorrect: | ||
| (swiftlint autocorrect --format) | ||
| (swiftlint --fix --format) |
Contributor
There was a problem hiding this comment.
Will need to fix the git hook script as well as it uses autocorrect.
In addition, I think it would good to apply git hook scripts by changing the local git config to point to a .githooks folder we have in source control. It's something we did for the Edge Identity and Edge Consent projects.
https://github.com/adobe/aepsdk-edgeidentity-android/blob/dev/Makefile#L15
This allows updates to the git hook scripts without developers needing to recopy the pre-commit script to their local .git/hooks directory.
kevinlind
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: