[MOB-14372] Use XDM timestamp if present#198
Merged
nporter-adbe merged 2 commits intoadobe:devfrom Jun 3, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #198 +/- ##
==========================================
+ Coverage 94.29% 94.30% +0.02%
==========================================
Files 26 26
Lines 910 913 +3
==========================================
+ Hits 858 861 +3
Misses 52 52 |
nporter-adbe
commented
Jun 3, 2021
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "# Type a script or drag a script file from your workspace to insert its path.\nif which swiftlint >/dev/null; then\n swiftlint lint --config ../.swiftlint.yml Sources\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n\n"; | ||
| shellScript = "# Type a script or drag a script file from your workspace to insert its path.\nif which swiftlint >/dev/null; then\n swiftlint lint --config ${SRCROOT}/.swiftlint.yml Sources\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n\n"; |
Contributor
Author
There was a problem hiding this comment.
CI was failing stating it could not find the Swiftlint config file. Not sure why this change is needed all of a sudden.
kevinlind
approved these changes
Jun 3, 2021
emdobrin
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When xdm.timestamp is provided in the experience event payload preserve this value, otherwise set the event timestamp as xdm.timestamp.
Also sets the event timestamp when the provided value is nil or empty or has another type other than String.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: