Conversation
Add Issues Templates
Codecov Report
@@ Coverage Diff @@
## dev #193 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 26 26
Lines 910 910
=======================================
Hits 858 858
Misses 52 52 |
emdobrin
reviewed
May 7, 2021
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
| ## Prerequisites | ||
| <!--- Go through the items below before logging an issue --> | ||
| - [ ] Please search this repository's issues to see if it has already been reported. This helps reduce duplicate issues from being created. | ||
| - [ ] If this is a Security Disclosure please follow the guidelines in [CONTRIBUTING](../CONTRIBUTING.md). This helps keep folks from accidentally releasing vulnerabilities before the maintainers get a chance to fix the issue. |
Contributor
There was a problem hiding this comment.
Let's replace [CONTRIBUTING](../CONTRIBUTING.md) with [Security Policy](https://github.com/adobe/aepsdk-edge-ios/security/policy)
Contributor
Author
There was a problem hiding this comment.
I changed it pointing to the SECURITY.md file in the root folder
Update with review comments Add ISSUE_TEMPLATE.md, so open a blank report will pick this one. Add Security.md
nporter-adbe
reviewed
May 7, 2021
Update for review comments
Set swift code as default code format
Change the security policy link to relative path
emdobrin
approved these changes
May 7, 2021
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Looks good with a tiny comment
update bug_report platform question
Update the security link path in bug_report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Issues Chooser Templates
Description
When users go to Issues and open a new Issue, after this change, it will take to issue chooser page which will have three choices. They are bug report, feature request and Report a security vulnerability.
Open bug report and feature request will bring to a template which have pre-populated format to follow.
Report a security vulnerability will take to the SECURITY.md.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: