Update config.yml with SHA check for Codecov#190
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #190 +/- ##
==========================================
- Coverage 94.29% 94.18% -0.11%
==========================================
Files 26 25 -1
Lines 910 893 -17
==========================================
- Hits 858 841 -17
Misses 52 52 |
Add a fake codecov script to validate update to config.yml which fails upload if sha check fails.
Remove the code to download the codecov script used for the sha check. The checked in fake codecov script should be used instead to validate the bash script will fail the upload task.
Override shell in step to upload to Codecov in attempt to ensure a zero exit code is passed.
emdobrin
approved these changes
Apr 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Codecov publish step to include a check of the SHA hash of the downloaded uploader script. The step will check each of SHA1, SHA256, and SHA512 hashes hosted by Codecov for the specific version of the uploader script which was downloaded. If the
shasumcheck fails, the Circlci step will fail before uploading the coverage reports and in turn fail the build.https://docs.codecov.io/docs/about-the-codecov-bash-uploader#validating-the-bash-script
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: