Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #148 +/- ##
========================================
Coverage 93.06% 93.06%
========================================
Files 20 20
Lines 620 620
========================================
Hits 577 577
Misses 43 43 |
emdobrin
reviewed
Jan 19, 2021
| pod 'AEPRulesEngine', :git => 'git@github.com:adobe/aepsdk-rulesengine-ios.git', :tag => 'main' | ||
| pod 'AEPCore' | ||
| pod 'AEPServices' | ||
| pod 'AEPRulesEngine' |
Contributor
There was a problem hiding this comment.
Can we remove AEPServices and AEPRulesEngine and rely on AEPCore to bring those (same below)
Contributor
Author
There was a problem hiding this comment.
Yeah, it's not required to specify them. My thought on including these directly is that it gives us a little more flexibility during development to pull in specific versions of services and rules engine if we want a specific version/branch for testing/dev purposes.
emdobrin
approved these changes
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dependencies to GA versions.