Make public APIs ObjC Compatible#138
Merged
nporter-adbe merged 1 commit intoadobe:stagingfrom Jan 15, 2021
Merged
Conversation
emdobrin
reviewed
Jan 15, 2021
| /// - data: Any free form data in a [String : Any] dictionary structure. | ||
| /// - datasetIdentifier: The Experience Platform dataset identifier where this event should be sent to; if not provided, the default dataset identifier set in the Edge configuration is used | ||
| public init(xdm: [String: Any], data: [String: Any]? = nil, datasetIdentifier: String? = nil) { | ||
| @objc public init(xdm: [String: Any], data: [String: Any]? = nil, datasetIdentifier: String? = nil) { |
Contributor
There was a problem hiding this comment.
Any changes we need to do to XDMSchema or XDMFormatters?
EdgeEventHandle seems correct, but please test with that too.
Contributor
Author
There was a problem hiding this comment.
We can easily make XDMFormatters compatible with Objc, but XDMSchema is a bit of a different story due to the Encoadable requirement.
Codecov Report
@@ Coverage Diff @@
## dev #138 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 20 20
Lines 616 616
=======================================
Hits 575 575
Misses 41 41 |
emdobrin
approved these changes
Jan 15, 2021
kevinlind
approved these changes
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current APIs do not allow for creating an Event or sending an Event in ObjC.