Do not encode eventIndex for EdgeEventHandle/Error/Warning#136
Merged
Do not encode eventIndex for EdgeEventHandle/Error/Warning#136
Conversation
…eEventWarning. The event index is not required for extensions listening on Edge response events, so by not encoding it is not available in the dispatched Event.
Codecov Report
@@ Coverage Diff @@
## dev #136 +/- ##
==========================================
+ Coverage 93.18% 93.34% +0.17%
==========================================
Files 18 20 +2
Lines 601 616 +15
==========================================
+ Hits 560 575 +15
Misses 41 41 |
emdobrin
reviewed
Jan 14, 2021
nporter-adbe
approved these changes
Jan 14, 2021
emdobrin
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not encode eventIndex for EdgeEventHandle, EdgeEventError, and EdgeEventWarning.
The event index is not required for extensions listening on Edge response events, so by not encoding it is not available in the dispatched Event.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: